Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Add support of true built-in type (from PHP 8.2)#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedJun 15, 2022•
edited by nicolas-grekas
Loading

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

RFC:https://wiki.php.net/rfc/true-type
Pull request:php/php-src#8326

Same as this PR to add support offalse andnull types:#45981

@carsonbotcarsonbot added this to the4.4 milestoneJun 15, 2022
@carsonbotcarsonbot changed the title[Serializer][PropertyInfo] Add support of true built-in type (from PHP 8.2)[PropertyInfo][Serializer] Add support of true built-in type (from PHP 8.2)Jun 15, 2022
@fabpot
Copy link
Member

That's a new feature that should be part of 6.2. Merging#45981 in 4.4 was a mistake.
I'm all for making 4.4 compatible with 8.2 because the code should work well with 8.2, but adding new features is a no-go for me.
If one wants to use newer PHP features, they need to update to the latest Symfony version; I think it makes sense.

maxhelias and dunglas reacted with thumbs up emoji

@alexandre-daubois
Copy link
MemberAuthor

alexandre-daubois commentedJun 17, 2022•
edited
Loading

Thank you for the feedback@fabpot! I understand and agree your point of view on new PHP features. I'll do the necessary changes (if any) and rebase this to 6.2 👍

@alexandre-dauboisalexandre-daubois changed the base branch from4.4 to6.2June 17, 2022 08:15
@alexandre-dauboisalexandre-dauboisforce-pushed thefix-true-builtin-type branch 2 times, most recently from0608808 toc3dafbdCompareJune 17, 2022 08:17
@nicolas-grekasnicolas-grekas modified the milestones:4.4,6.2Jun 19, 2022
@carsonbotcarsonbot changed the title[PropertyInfo][Serializer] Add support of true built-in type (from PHP 8.2)[Serializer] Add support of true built-in type (from PHP 8.2)Jun 20, 2022
@nicolas-grekas
Copy link
Member

Thank you@alexandre-daubois.

@nicolas-grekasnicolas-grekas merged commit1ded85f intosymfony:6.2Jun 20, 2022
@alexandre-dauboisalexandre-daubois deleted the fix-true-builtin-type branchJune 20, 2022 12:26
@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mtarldmtarldmtarld approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@derrabusderrabusAwaiting requested review from derrabus

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

8 participants

@alexandre-daubois@fabpot@nicolas-grekas@dunglas@derrabus@mtarld@maxhelias@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp