Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] Fix json encode flags usage in copy-as-curl generation#46670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.1fromwelcoMattic:fix/http-client-data-collector-json-encodeJun 19, 2022
Merged
[HttpClient] Fix json encode flags usage in copy-as-curl generation#46670
nicolas-grekas merged 1 commit intosymfony:6.1fromwelcoMattic:fix/http-client-data-collector-json-encodeJun 19, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
f1392ae to1210828CompareUh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
1210828 tobb0ddf1Comparenicolas-grekas approved these changesJun 16, 2022
Member
nicolas-grekas commentedJun 19, 2022
Thank you@welcoMattic. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The
json_encode($json, \JSON_PRETTY_PRINT)call to generate the cURL version of a HTTP Request in HttpClientDataCollector didn't use theself::jsonEncodemethod available.The main issue with that is the usage of
\JSON_PRETTY_PRINT, which is overwrites all other flags inself::jsonEncodemethod, especially\JSON_PRESERVE_ZERO_FRACTION.So I have added a test for it:
After the changes, this test pass ✅
I've added test for all other flags, to be sure that they are used. It could lead to less readable JSON (with hex values) displayed in Profiler, but it's more accurate to debug.
EDIT: removing
\JSON_PRETTY_PRINTsolve the problem too, and we don't need to pretty-print the JSON in curl command, it allows to run theexact same request.