Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Lower JsonSerializableNormalizer priority#46668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

aprat84
Copy link
Contributor

@aprat84aprat84 commentedJun 14, 2022•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

IMHO, more generic normalizers, likeObjectNormalizer orJsonSerializableNormalizer should have lower priority than other more specific normalizers, likeDateTimeNormalizer,ConstraintViolationListNormalizer, etc.

My issue was withCarbon library, which extends php'sDateTime.
Carbon classes implementJsonSerializable interface, so they are serialized withJsonSerializableNormalizer, using its internaltoJSON() method, so I can't control which format I want them to be serialized.
I should be able to do it, as I can withDateTime, cause both implementDateTimeInterface.

That's becauseJsonSerializableNormalizer has higher priority thanDateTimeNormalizer.

For now, my "fix" was to change priority in config like so:

serializer.normalizer.json_serializable:class:Symfony\Component\Serializer\Normalizer\JsonSerializableNormalizertags:            -{name: 'serializer.normalizer', priority: -950 }

ramoncarreras reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@aprat84aprat84force-pushed thejson-normalizer-priority branch froma4659b6 to3fcfc20CompareJune 14, 2022 12:26
@nicolas-grekas
Copy link
Member

Thank you@aprat84.

aprat84 reacted with rocket emoji

@nicolas-grekasnicolas-grekas merged commitaac6436 intosymfony:4.4Jun 19, 2022
This was referencedJun 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dunglasdunglasdunglas approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

4 participants
@aprat84@carsonbot@nicolas-grekas@dunglas
[8]ページ先頭
©2009-2025 Movatter.jp