Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle] Disable Serializer data collect by default#46625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mtarld approved these changesJun 9, 2022
Member
nicolas-grekas commentedJun 9, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Do we want to enable this by default for new projects via a recipe? Can you please send a PR doing so if yes? |
nicolas-grekas approved these changesJun 9, 2022
Thank you@chalasr. |
Here is the recipe PRsymfony/recipes#1095 |
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestAug 11, 2022
…r.collect_serializer_data` option (chalasr)This PR was merged into the 6.1 branch.Discussion----------[FrameworkBundle] Document the `framework.profiler.collect_serializer_data` optionDocuments the option added insymfony/symfony#46625.Commits-------e33e717 [FrameworkBundle] Document the `framework.profiler.collect_serializer_data` option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The serializer data collector introduced in 6.1. causes a BC break for some (see fixed ticket).
This PR adds a
framework.profiler.collect_serializer_dataoption defaulting tofalse, allowing people to fix their code before activating it.Next steps:
ObjectNormalizerautowiring alias on 6.2 and fix the docs accordinglyBuild failures unrelated.