NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DependencyInjection] [POC] allow`ServiceSubscriberTrait` to autowire properties#46617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

kbond wants to merge1 commit intosymfony:6.4fromkbond:service-subscriber-properties

Closed

[DependencyInjection] [POC] allow`ServiceSubscriberTrait` to autowire properties#46617

kbond wants to merge1 commit intosymfony:6.4fromkbond:service-subscriber-properties

Conversation

Copy link

Member

kbond commentedJun 7, 2022•
edited
Loading

Q	A
Branch?	6.2
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	todo

This comes from a slack discussion with@nicolas-grekas.

This PR allowsServiceSubscriberInterface services using theServiceSubscriber trait toautowire properties marked with theSubscribedService attribute.

class MyServiceimplements ServiceSubscriberInterface{use ServiceSubscriberTrait;    #[SubscribedService]privateAnotherService$anotherService;publicfunctionsomeMethod()    {$this->anotherService->something();// lazily initializes the property the first time it's accessed    }}

TODO:

nullable properties?
more tests
changelog

carsonbot added Status: Needs Review DependencyInjection Feature labels

Jun 7, 2022

carsonbot added this to the6.2 milestone

Jun 7, 2022

carsonbot changed the title~~[POC][DI] allowServiceSubscriberTrait to autowire properties~~[DependencyInjection] [POC] allowServiceSubscriberTrait to autowire properties

Jun 7, 2022

kbond force-pushed theservice-subscriber-properties branch 2 times, most recently from187925e todeeb6fdCompare

June 7, 2022 22:01

nicolas-grekas reviewed

Jul 28, 2022

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Many interesting challenges here, that's very much R&D :)

src/Symfony/Contracts/Service/ServiceSubscriberTrait.php Outdated

		$this->container =$container;

		if ($containerinstanceof ServiceProviderInterface) {
		// TODO: what if this isn't an instance of ServiceProviderInterface?

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should use reflection instead of relying on ServiceProviderInterface and unset only the properties that have the attribute

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This would be at runtime, that ok?

src/Symfony/Contracts/Service/ServiceSubscriberTrait.php OutdatedShow resolvedHide resolved

src/Symfony/Contracts/Service/ServiceSubscriberTrait.php

		{
		// TODO: ensure cannot be called from outside of the scope of the object?
		// TODO: what if class has a child/parent that allows this?
		// TODO: call parent::__get()?

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LazyGhostObjectTrait to the rescue somehow?

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not very familiar with this trait. How could it be used?

src/Symfony/Contracts/Tests/Service/ServiceSubscriberTraitTest.php OutdatedShow resolvedHide resolved

src/Symfony/Contracts/Service/Attribute/SubscribedService.php OutdatedShow resolvedHide resolved

nicolas-grekas added Status: Needs Work and removed Status: Needs Review labels

Jul 28, 2022

kbond force-pushed theservice-subscriber-properties branch 3 times, most recently from56b0944 to573b694Compare

August 29, 2022 13:31

[DI] allowServiceSubscriberTrait to autowire properties

e2fb640

kbond force-pushed theservice-subscriber-properties branch from573b694 toe2fb640Compare

August 29, 2022 13:35

nicolas-grekas modified the milestones:6.2,6.3

Nov 5, 2022

nicolas-grekas modified the milestones:6.3,6.4

May 23, 2023

Copy link

Member

nicolas-grekas commentedSep 13, 2023•
edited
Loading

I'm closing here because while this is an interesting topic, I feel like this would bring too much complexity in comparison to other approaches based on Autowire attributes, especially since#51392
Thanks for giving the idea a try!

nicolas-grekas closed this

Sep 13, 2023

Labels

DependencyInjection Feature Status: Needs Work

Movatterモバイル変換

Uh oh!

[DependencyInjection] [POC] allowServiceSubscriberTrait to autowire properties#46617

[DependencyInjection] [POC] allowServiceSubscriberTrait to autowire properties#46617

Uh oh!

Conversation

kbond commentedJun 7, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

nicolas-grekasJul 28, 2022

Choose a reason for hiding this comment

Uh oh!

kbondAug 29, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicolas-grekasJul 28, 2022

Choose a reason for hiding this comment

Uh oh!

kbondAug 29, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commentedSep 13, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[DependencyInjection] [POC] allow`ServiceSubscriberTrait` to autowire properties#46617

[DependencyInjection] [POC] allow`ServiceSubscriberTrait` to autowire properties#46617

kbond commentedJun 7, 2022•
edited
Loading

nicolas-grekas commentedSep 13, 2023•
edited
Loading