Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyInfo] Fix multi phpdoc covered promoted properties#46611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 2 commits intosymfony:6.1fromsimPod:property-info
Jun 10, 2022

Conversation

@simPod
Copy link
Contributor

QA
Branch?6.1
Bug fix?yes
TicketsFix#46550
LicenseMIT

I came up with this solution

@simPodsimPod requested a review fromdunglas as acode ownerJune 7, 2022 08:38
@carsonbotcarsonbot added this to the6.2 milestoneJun 7, 2022
@simPodsimPod changed the base branch from6.2 to6.1June 7, 2022 08:38
@carsonbot
Copy link

Hey!

I think@Korbeil has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

/cc@ostrolucky in case you can come up with another failing test case? or is this robust enough?

@ostrolucky
Copy link
Contributor

With this, maybe my patch at#46453 is not necessary anymore?

@ostrolucky
Copy link
Contributor

Going to answer my own comment

if (self::MUTATOR ===$source && !$this->filterDocBlockParams($phpDocNode,$property)) {returnnull;}

this guard can now indeed by removed, since you added more generic solution.

ostroluckyand others added2 commitsJune 10, 2022 09:48
…d propertiesThis demonstrates thatsymfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
@simPod
Copy link
ContributorAuthor

Indeed, cool

@nicolas-grekas
Copy link
Member

Thank you@simPod.

@nicolas-grekasnicolas-grekas merged commitbf255fa intosymfony:6.1Jun 10, 2022
@nicolas-grekas
Copy link
Member

And thank you@ostrolucky also.

@simPodsimPod deleted the property-info branchJune 10, 2022 09:37
@fabpotfabpot mentioned this pull requestJun 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@ostroluckyostroluckyostrolucky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

4 participants

@simPod@carsonbot@ostrolucky@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp