Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Fix deprecation when description is null#46608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

HypeMC
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Fixesstr_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated whengetDefaultDescription() returnsnull, caused by#46574.

@@ -56,6 +56,7 @@ public function process(ContainerBuilder $container)
foreach ($commandServices as $id => $tags) {
$definition = $container->getDefinition($id);
$definition->addTag($this->noPreloadTag);
/** @var class-string<Command> $class */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change looks unrelated and should be reverted.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done

str_replace(): Passing null to parametersymfony#3 ($subject) of type array|string is deprecated
@HypeMCHypeMCforce-pushed thefix-deprecation-when-description-is-null branch fromae00115 to7a08b52CompareJune 7, 2022 04:48
@fabpot
Copy link
Member

Good catch, thanks@HypeMC.

@fabpotfabpot merged commit2cbbec4 intosymfony:5.4Jun 7, 2022
@HypeMCHypeMC deleted the fix-deprecation-when-description-is-null branchJune 7, 2022 06:14
@fabpotfabpot mentioned this pull requestJun 9, 2022
This was referencedJun 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

4 participants
@HypeMC@fabpot@derrabus@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp