Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add "negate" option to Expression constraint#46599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I like the idea but struggle a bit with "pass" naming. What about "negate" or sth else? |
@OskarStark better 👍 pushed. |
fabpot approved these changesJul 21, 2022
Thank you@fmata. |
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestJul 22, 2022
… option (Florent Mata)This PR was merged into the 6.2 branch.Discussion----------[Validator] Update Expression constraint with "negate" optionsymfony/symfony#46599Commits-------0ca9832 Update Expression constraint with "negate" option
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Using
Expressionconstraint is tedious because the written expression is the opposite of the error message. Addingnegateoption (naming ?) asRegex::$matchallow us to write condition in phase with the wording.