NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[DependencyInjection] Add Enum Env Var Processor#46564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.2fromjack-worman:EnumEnvVarProcessor

Jun 27, 2022

Merged

[DependencyInjection] Add Enum Env Var Processor#46564

nicolas-grekas merged 1 commit intosymfony:6.2fromjack-worman:EnumEnvVarProcessor

Jun 27, 2022

Conversation

Copy link

Contributor

jack-worman commentedJun 2, 2022•
edited
Loading

Q	A
Branch?	6.2
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	N/A
License	MIT
Doc PR	waiting on approval of feature

Add the ability to transform env variables into \BackedEnums.

For example, you could now autowire an enum from an environment variable:

<?phpuseSymfony\Component\DependencyInjection\Attribute\Autowire;enum AppEnv:string {case Test ='test';case Dev ='dev';case Stage ='stage';case Prod ='prod';}class Foo {publicfunction__construct(        #[Autowire('%env(enum:'.AppEnv::class.':APP_ENV)%')]privateAppEnv$appEnv,    ) {}}

carsonbot added Status: Needs Review DependencyInjection Feature labels

Jun 2, 2022

carsonbot added this to the6.2 milestone

Jun 2, 2022

Copy link

carsonbot commentedJun 3, 2022

Hey!

I think@ruudk has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link

Member

nicolas-grekas commentedJun 24, 2022

This might miss some pieces as I think some regexps like this one might prevent using FQCN in%env()% parameters:

symfony/src/Symfony/Component/DependencyInjection/ParameterBag/EnvPlaceholderParameterBag.php

Line 47 inbbf25d6

if (!preg_match('/^(?:[-.\w]*+:)*+\w++$/',$env)) {

Copy link

Member

nicolas-grekas commentedJun 24, 2022

Please update the description of the PR to make it clear what you're proposing. I could guess by looking at the tests, but providing a proper PR description is nonetheless a good thing to help ppl understand what this is about, and start the doc later on.

nicolas-grekas reviewed

Jun 24, 2022

View reviewed changes

src/Symfony/Component/DependencyInjection/CHANGELOG.md OutdatedShow resolvedHide resolved

src/Symfony/Component/DependencyInjection/EnvVarProcessor.php OutdatedShow resolvedHide resolved

src/Symfony/Component/DependencyInjection/Loader/Configurator/EnvConfigurator.phpShow resolvedHide resolved

src/Symfony/Component/DependencyInjection/Tests/Fixtures/IntBackedEnum.php OutdatedShow resolvedHide resolved

src/Symfony/Component/DependencyInjection/Tests/Loader/Configurator/EnvConfiguratorTest.php OutdatedShow resolvedHide resolved

nicolas-grekas approved these changes

Jun 27, 2022

View reviewed changes

src/Symfony/Component/DependencyInjection/EnvVarProcessor.php OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 27, 2022

nicolas-grekas reviewed

Jun 27, 2022

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.phpShow resolvedHide resolved

nicolas-grekas reviewed

Jun 27, 2022

View reviewed changes

src/Symfony/Component/DependencyInjection/EnvVarProcessor.php OutdatedShow resolvedHide resolved

stof approved these changes

Jun 27, 2022

View reviewed changes

Copy link

Member

nicolas-grekas commentedJun 27, 2022

A next step could be to find a way to make autowiring do its part, so that theenum: prefix wouldn't be needed.
But that's for another PR :)

👍

Copy link

Member

nicolas-grekas commentedJun 27, 2022•
edited
Loading

Can you please rebase on latest 6.2? We don't merge PRs with merge commits. If you want to squash while doing so, please do (we'll do it when merging otherwise.)