Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Fix AJAX requests info are truncated in the WDT#46507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tucksaun
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#45741?, replaces#46495 ?
LicenseMIT
Doc PRn/a

At some point (I guess during the WDT redesign,#15160), something changed making the AJAX request table in the WDT just a little bit larger.
This causes the requests to be truncated when the URL is too long:
Screenshot 2022-05-30 at 10 21 51

This PR fixes this by increasing the max-width of the WDT info panel to 525px:
Screenshot 2022-05-30 at 10 22 20

We could reduce the width of the request table to fit in, but 525px seems reasonable enough nowadays and provides more information about the URL.

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like this change ... but I think it doesn't fully solve the issues mentioned in#45741.

I'd merge this one without closing#45741 yet to see if we think of an additional solution.

@tucksaun
Copy link
ContributorAuthor

looks a good plan@javiereguiluz 👌

Regarding a best solution: in#46495 you mention having the full URL as a title to be able to have it shown by hovering it.
This is already the case:

@nicolas-grekas
Copy link
Member

Thank you@tucksaun.

@nicolas-grekasnicolas-grekas merged commit051f5a4 intosymfony:4.4May 31, 2022
@ghost
Copy link

@nicolas-grekas The issue is that this might be a patch solution I am afraid. You can see it here,
#45741 (comment)

@tucksauntucksaun deleted the wdt-ajax-infos-truncated branchMay 31, 2022 17:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@tucksaun@nicolas-grekas@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp