Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Bootstrap 4 fieldset for row errors#46414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Bootstrap 4 fieldset for row errors#46414
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 20, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas commentedMay 21, 2022
Thank you@konradkozaczenko. |
| <divclass="{{block('form_group_class') }}"> | ||
| {{- form_widget(form,widget_attr) -}} | ||
| {{- form_help(form) -}} | ||
| {{- form_errors(form) -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this really necessary as the errors should be rendered when the label is rendered?
Uh oh!
There was an error while loading.Please reload this page.
When using bootstrap_4_horizontal_layout.html and ChoiceType on a form with expanded and multiple options, the checkbox list is rendered, but no errors are displayed. My changes only affect bootstrap version 4. Bootstrap 5 already has these changes.