Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix dumping extension config without bundle#46412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedMay 21, 2022
Thank you@yceruto. |
| * @return ExtensionInterface | ||
| */ | ||
| protectedfunctionfindExtension($name) | ||
| protectedfunctionfindExtension($name,ContainerBuilder$container) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that's a BC break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My bad!
I don't remember, is it ok to add a new deprecation in a patch version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We cannot do that in a patch release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed in#46434
… (yceruto)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle] Fix BC break in abstract config commands| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Fixes#46412This revert also the unnecessary changes made in ConfigDebugCommand and ConfigDumpReferenceCommand classesCommits-------5be61fa Fix BC break
Either the
debug:configorconfig:dump-referencecommands allow to pass the bundle name or the extension alias as first argument. However, when we register an extension without a bundle (i.e. it's directly registered in the kernel class or the kernel class implementsExtensionInterface), these commands cannot dump the configuration related to this extension.This PR fixes the issue, so both commands will look at the extensions list regardless of whether it belongs to a bundle.