Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Throw when "redis_sentinel" is used with a non-Predis "class" option#46401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
buffcode commentedMay 18, 2022
AppVeyor check result seems to be unrelated, tests are successful but the job times out: |
carsonbot commentedMay 19, 2022
Hey! I think@jonashrem has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Member
nicolas-grekas commentedMay 21, 2022
Thank you@buffcode. |
nicolas-grekas added a commit that referenced this pull requestMay 21, 2022
…dis "class" option (buffcode)This PR was merged into the 4.4 branch.Discussion----------[Cache] Throw when "redis_sentinel" is used with a non-Predis "class" option| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| License | MITEnforce usage of `\Predis\Client` when the `redis_sentinel` option is enabled.Otherwise it is possible to give the option `class: Redis`, which will setup the connection without any error but fail to work, because the Redis commands will be issued against the Sentinel instances instead of the Redis instances.Commits-------cdc9414 [Cache] Throw when "redis_sentinel" is used with a non-Predis "class" option
This was referencedMay 27, 2022
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce usage of
\Predis\Clientwhen theredis_sentineloption is enabled.Otherwise it is possible to give the option
class: Redis, which will setup the connection without any error but fail to work, because the Redis commands will be issued against the Sentinel instances instead of the Redis instances.