Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Contact Everyone Bridge#46395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@franckranaivo
Copy link
Contributor

@franckranaivofranckranaivo commentedMay 18, 2022•
edited
Loading

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRTODO

Add Contact Everyone Bridge by Orange Business.

This bridge uses the light version of the api which allows SMS to be sent individually.

maxonss reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStarkOskarStark modified the milestones:6.1,6.2May 18, 2022
@franckranaivofranckranaivoforce-pushed thecontact-everyone-notifier branch 2 times, most recently from868cf5a to723ad78CompareMay 19, 2022 13:12
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you please open a PR onsymfony-docs repo? Thanks

@OskarStark
Copy link
Contributor

@fabpot is it possible to to add this exception to fabbot.io?
CleanShot 2022-05-19 at 22 33 36@2x

@OskarStark
Copy link
Contributor

friendly ping@fabpot

franckranaivo reacted with thumbs up emoji

{
$dsn = sprintf('contact-everyone://%s', $this->getEndpoint());

if (null !== $this->diffusionName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
if (null !==$this->diffusionName) {
if ($this->diffusionName) {

franckranaivo reacted with thumbs up emoji
$dsn .= sprintf('?diffusionname=%s', $this->diffusionName);
}

if (null !== $this->category) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
if (null !==$this->category) {
if ($this->category) {

franckranaivo reacted with thumbs up emoji
- `DIFFUSION_NAME` (optional) allows you to define the label of the diffusion that will be displayed in the event logs.
- `CATEGORY` (optional) allows you to define the label of the category that will be displayed in the event logs.

This bridge uses the light version of Contact Everyone api.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
This bridge uses the light version of Contact Everyoneapi.
This bridge uses the light version of Contact EveryoneAPI.

franckranaivo reacted with thumbs up emoji
```

where:
- `TOKEN` is your Contact Everyone api token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
-`TOKEN` is your Contact Everyoneapi token
-`TOKEN` is your Contact EveryoneAPI token

franckranaivo reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@franckranaivo.

franckranaivo reacted with heart emoji

@fabpot
Copy link
Member

@franckranaivo Can you submit a PR for a recipe? Something like this:https://github.com/symfony/recipes/pull/1102/files
And a PR for the docs?
Thank you.

@franckranaivo
Copy link
ContributorAuthor

Sure. Thank you@fabpot forsymfony/symfony-docs#16915 for the PR Docs.

@fabpotfabpot mentioned this pull requestOct 24, 2022
@franckranaivofranckranaivo deleted the contact-everyone-notifier branchMarch 22, 2023 09:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@stofstofAwaiting requested review from stof

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

5 participants

@franckranaivo@carsonbot@OskarStark@fabpot@stof
[8]ページ先頭
©2009-2025 Movatter.jp