Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console]  Fix missing negative variation of negatable options in shell completion#46386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromGromNaN:complete-negatable
May 27, 2022

Conversation

@GromNaN
Copy link
Member

@GromNaNGromNaN commentedMay 17, 2022
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRn/a

Add negation ofnegatable options in bash completion output.

2nd PR for Fish, targeting branch 6.1:#46387

@GromNaNGromNaN requested a review fromwouterjMay 17, 2022 21:11
@GromNaNGromNaN requested a review fromchalasr as acode ownerMay 17, 2022 21:11
@carsonbotcarsonbot added this to the5.4 milestoneMay 17, 2022
@carsonbotcarsonbot changed the title[Console] Complete negatable options[Console]  Complete negatable optionsMay 17, 2022
@GromNaNGromNaNforce-pushed thecomplete-negatable branch 4 times, most recently from1d7cdd1 to273c505CompareMay 18, 2022 06:16
@GromNaN
Copy link
MemberAuthor

appveyor error not related to this PR:Messenger\Bridge\Redis.

@fabpot
Copy link
Member

That's a new feature, so 6.2.

@stof
Copy link
Member

Well, to me, that's a bugfix of the completion of option names

GromNaN and wouterj reacted with thumbs up emoji

@chalasr
Copy link
Member

I agree it's a bugfix.

@fabpot
Copy link
Member

No, it's not. Even the description is clear about that: "Add negation ofnegatable options". Adding something is not a bug fix (or at least, not anymore).

@stof
Copy link
Member

Well, the same description could be written as "ensure that all option names are completable for negatable options"

@chalasr
Copy link
Member

Yea, I thought the same when reading the description. My reasoning is that completion should seamlessly handle any kind of option, otherwise it's buggy.

@GromNaN
Copy link
MemberAuthor

GromNaN commentedMay 18, 2022
edited
Loading

Shell completion is a form of documentation of the available options. Not suggesting the negative form--no-ansi is a defect that leads to a failure to understand for users of CLI tools. It would be a shame to have this bug once Composer enable completion.

@GromNaNGromNaN changed the title[Console]  Complete negatable options[Console]  Fix missing negative variation of negatable options in shell completionMay 19, 2022
@GromNaN
Copy link
MemberAuthor

I think the tester should be fixed also.

chalasr reacted with thumbs up emoji

fabpot added a commit that referenced this pull requestMay 27, 2022
This PR was squashed before being merged into the 6.1 branch.Discussion----------[Console] Complete negatable options (Fish)| Q             | A| ------------- | ---| Branch?       | 6.1| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | n/a| License       | MIT| Doc PR        | n/aSame as#46386 for Fish (introduced in 6.1).Commits-------02b7b52 [Console] Complete negatable options (Fish)
@fabpot
Copy link
Member

Thank you@GromNaN.

@fabpotfabpot merged commitf79ed9a intosymfony:5.4May 27, 2022
This was referencedMay 27, 2022
@GromNaNGromNaN deleted the complete-negatable branchMay 27, 2022 12:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@GromNaN@fabpot@stof@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp