Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fix missing negative variation of negatable options in shell completion#46386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
1d7cdd1 to273c505CompareGromNaN commentedMay 18, 2022
appveyor error not related to this PR: |
fabpot commentedMay 18, 2022
That's a new feature, so 6.2. |
stof commentedMay 18, 2022
Well, to me, that's a bugfix of the completion of option names |
chalasr commentedMay 18, 2022
I agree it's a bugfix. |
fabpot commentedMay 18, 2022
No, it's not. Even the description is clear about that: "Add negation ofnegatable options". Adding something is not a bug fix (or at least, not anymore). |
stof commentedMay 18, 2022
Well, the same description could be written as "ensure that all option names are completable for negatable options" |
chalasr commentedMay 18, 2022
Yea, I thought the same when reading the description. My reasoning is that completion should seamlessly handle any kind of option, otherwise it's buggy. |
GromNaN commentedMay 18, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Shell completion is a form of documentation of the available options. Not suggesting the negative form |
GromNaN commentedMay 23, 2022
I think the tester should be fixed also.
|
This PR was squashed before being merged into the 6.1 branch.Discussion----------[Console] Complete negatable options (Fish)| Q | A| ------------- | ---| Branch? | 6.1| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | n/a| License | MIT| Doc PR | n/aSame as#46386 for Fish (introduced in 6.1).Commits-------02b7b52 [Console] Complete negatable options (Fish)
fabpot commentedMay 27, 2022
Thank you@GromNaN. |
Uh oh!
There was an error while loading.Please reload this page.
Add negation ofnegatable options in bash completion output.
2nd PR for Fish, targeting branch 6.1:#46387