Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mime] Throw exception when body in Email attach method is not ok#46367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alamirault
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#45350
LicenseMIT
Doc PRsymfony/symfony-docs#...

As proposed in#45350, throw exception when calling(new Email())->attach($badBodyType); when type is not supported

@carsonbotcarsonbot added this to the4.4 milestoneMay 16, 2022
@alamiraultalamiraultforce-pushed thefix-45350-exception-when-invalid-attach branch from402997f to30f7dc8CompareMay 16, 2022 20:04
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few more methods would need the check, egembed()


/**
* @param resource|string $body
* @param resource|string|null $body
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Was not documented before but null car be pass

@nicolas-grekasnicolas-grekasforce-pushed thefix-45350-exception-when-invalid-attach branch fromd8a0ee1 to8561c4eCompareMay 21, 2022 10:11
@nicolas-grekas
Copy link
Member

Thank you@alamirault.

@nicolas-grekasnicolas-grekas merged commitf3df3d0 intosymfony:4.4May 21, 2022
This was referencedMay 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@alamirault@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp