Hey!

I think@edefimov has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@wouterj@chalasr friendly ping as code owner
does this small feature would be accepted so I can continue working on the PR (tests etc ?)

many thanks !

Thanks for the ping@94noni, this looks sensible to me.

Should we throw an error if bothtarget_url andstateless are set?

@chalasr I appreciate the fast feedback!

this looks sensible to me. Should we throw an error if both target_url and stateless are set?

I will check this part as I know a little bit on this side
Are you thinking on any pitfall regarding this?

@94noni It's just about DX: setting atarget_url on a stateless firewall does not make sense as there is no redirect in that case, hence forbidding that combination would make sense I think. Better be explicit than silent :) especially in the security area. That check could be done in SecurityExtension::createSwitchUserListener

@chalasr Indeed it makes sens, I will have a deeper look at it soon, thx

status: needs work

@chalasr I've tried to implement yourrequest comment

feel free to give me feedbacks :)

Thank you@94noni.