Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] Fixes max_duration not being respected#46330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
As reported onsymfony#46316, when a request gets a successful response in further attempts, the max_duration is not respected and the request may take longer than the value specified here.My way to solve the issue was by reducing the timeout option in future requests, making it smaller in every attempt. By doing so, the total time of a $client->request will never be much longer than max_duration. Perhaps a second or two maybe, due to the waiting time between requests, but not as much as the timeout.
carsonbot commentedMay 12, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas commentedMay 17, 2022
Replaced by#46382 |
…with async decorators (nicolas-grekas)This PR was merged into the 5.4 branch.Discussion----------[HttpClient] Honor "max_duration" when replacing requests with async decorators| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#46316| License | MIT| Doc PR | -Instead of#46330Commits-------c81d116 [HttpClient] Honor "max_duration" when replacing requests with async decorators
Uh oh!
There was an error while loading.Please reload this page.
As reported on#46316, when a request gets a successful response in further attempts, the max_duration is not respected and the request may take longer than the value specified here.
My way to solve the issue was by reducing the timeout option in future requests, making it smaller in every attempt. By doing so, the total time of a $client->request will never be much longer than max_duration. Perhaps a second or two maybe, due to the waiting time between requests, but not as much as the timeout.