Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

SMTP Transport to provide the (final) Message-ID if available#46326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromdrzraf:mailer-smtp-message-id
Jul 20, 2022

Conversation

@drzraf
Copy link

bug#46323 [Mailer] SMTP transport does not provide the (final) Message-ID

QA
Branch?6.1
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#46323
LicenseMIT
Doc PRsymfony/symfony-docs#

Questions / Answers:

  • Q: Why storing 250 inside$mtaResult instead of using the already available$message->getDebug()?
  • A: Because the later may be huge (especially in case of attachment) and running a regexp over it would be less than safe. Instead$mtaResult only contains one line
  • Q: Why a newpublic method?
  • A: Because child SMTP Transport may make other assumptions about the return250 Ok value and provide a custom logic / regexp.
  • Q: Whyregexp?
  • A: Because there is no official standard for this line (other than the250 Ok prefix)

Additionally (seehttps://symfony.com/releases):

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@drzrafdrzraf changed the titleSMTP Transport to provide the (final) Message-ID if available[Mailer] SMTP Transport to provide the (final) Message-ID if availableMay 11, 2022
@carsonbot
Copy link

Hey!

I think@dmaicher has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[Mailer] SMTP Transport to provide the (final) Message-ID if availableSMTP Transport to provide the (final) Message-ID if availableMay 12, 2022
@fabpotfabpot modified the milestones:6.1,6.2May 13, 2022
@drzraf
Copy link
Author

drzraf commentedMay 24, 2022
edited
Loading

ping@stof

(Review addressed)

@fabpotfabpotforce-pushed themailer-smtp-message-id branch from60d0085 to441c9b0CompareJuly 20, 2022 17:35
@fabpot
Copy link
Member

Thank you@drzraf.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[Mailer][Amazon] SMTP transport does not provide the (final) Message-ID

4 participants

@drzraf@carsonbot@fabpot@stof

[8]ページ先頭

©2009-2025 Movatter.jp