Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Ldap] Fix LDAP connection options#46325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4frombuffcode:patch-1
May 14, 2022

Conversation

@buffcode
Copy link
Contributor

@buffcodebuffcode commentedMay 11, 2022•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

This PR adds support for theLDAP_OPT_X_TLS_CACERTFILE option in order to specify a CA file which should be used. It is available since the same PHP versionas the other options and may just have been forgotten.

Furthermore the connection options need to be applied at different stages in order to be effective.

Connection options are tagged to be preconnect-options and are executed beforeldap_connect, all other options continue to be applied betweenldap_connect andldap_bind.

Be aware thatthere is no LDAP documentation about which option is global and thus not requiring a connection and which needs one.

The preconnect options from this PR come from trial-and-error testing and mailing list entries at OpenLDAP.

Maybe also relevant:

trandbert37 reacted with hooray emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot added this to the6.1 milestoneMay 11, 2022
@carsonbotcarsonbot changed the titleadd support for CA cert file[Ldap] add support for CA cert fileMay 11, 2022
@buffcodebuffcode changed the title[Ldap] add support for CA cert file[Ldap] [WIP] Fix LDAP connection optionsMay 12, 2022
@buffcodebuffcode changed the base branch from6.1 to4.4May 12, 2022 07:02
@buffcodebuffcode changed the title[Ldap] [WIP] Fix LDAP connection options[Ldap] Fix LDAP connection optionsMay 12, 2022
@derrabusderrabus modified the milestones:6.1,4.4May 12, 2022
@carsonbot
Copy link

Hey!

I think @arekzb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Thank you@buffcode.

@nicolas-grekasnicolas-grekas merged commitddfb4a8 intosymfony:4.4May 14, 2022
@fabpotfabpot mentioned this pull requestMay 14, 2022
This was referencedMay 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@buffcode@carsonbot@nicolas-grekas@stof@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp