Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] "debug" is missing if a request failed to even start#46293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.1fromweaverryan:data-collector-invalid-requestMay 10, 2022
Merged
[HttpClient] "debug" is missing if a request failed to even start#46293
nicolas-grekas merged 1 commit intosymfony:6.1fromweaverryan:data-collector-invalid-requestMay 10, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
stof commentedMay 9, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Does the template handle well the case where the data does not have a |
MemberAuthor
weaverryan commentedMay 9, 2022
You're right - that is safer. Updated! |
stof approved these changesMay 10, 2022
aba0de3 to4beb320CompareMember
nicolas-grekas commentedMay 10, 2022
Thank you@weaverryan. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you do something really silly - like
$client->request('/foo')(where nobase_uriis configured), HttpClient correctly explodes with:However, in this situation, there will be no
debugkey in$trace. And so, currently on 6.1, instead of the above error, you see:Let me know if any changes are needed.
Thanks!