Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpClient] "debug" is missing if a request failed to even start#46293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@weaverryan
Copy link
Member

QA
Branch?6.1
Bug fix?yes
New feature?no
Deprecations?none
Ticketsnone
LicenseMIT
Doc PRnot needed

If you do something really silly - like$client->request('/foo') (where nobase_uri is configured), HttpClient correctly explodes with:

Invalid URL: scheme is missing in "/SymfonyCasts/vinyl-mixes/main/mixes.json". Did you forget to add "http(s)://"?

However, in this situation, there will be nodebug key in$trace. And so, currently on 6.1, instead of the above error, you see:

Warning: Undefined array key "debug"

Let me know if any changes are needed.

Thanks!

@stof
Copy link
Member

stof commentedMay 9, 2022
edited
Loading

Does the template handle well the case where the data does not have acurlCommand key ?
I think it would be safer to assign it tonull instead

@weaverryan
Copy link
MemberAuthor

I think it would be safer to assign it to null instead

You're right - that is safer. Updated!

@nicolas-grekasnicolas-grekasforce-pushed thedata-collector-invalid-request branch fromaba0de3 to4beb320CompareMay 10, 2022 07:57
@nicolas-grekas
Copy link
Member

Thank you@weaverryan.

@nicolas-grekasnicolas-grekas merged commit4106712 intosymfony:6.1May 10, 2022
@fabpotfabpot mentioned this pull requestMay 14, 2022
@weaverryanweaverryan deleted the data-collector-invalid-request branchMay 16, 2022 15:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

4 participants

@weaverryan@stof@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp