Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] Refresh local translations on PushCommand if the provider has domains#46239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 3, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| if (!$domains) { | ||
| if ($providerinstanceof FilteringProvider) { | ||
| $domains =$provider->getDomains(); | ||
| $localTranslations =$this->readLocalTranslations($locales,$domains,$this->transPaths); |
welcoMatticMay 3, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess it's better to not refresh translations, but read them after the mainif (!$domains) { block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was my first idea, but the variable$localTranslations is used in the if (!$domains) { block at line 143
| $domains =$this->getDomainsFromTranslatorBag($localTranslations); |
We can also rewrite the if (!$domains) { block a bit like this :
if (!$domains &&$providerinstanceof FilteringProvider) {$domains =$provider->getDomains();}$localTranslations =$this->readLocalTranslations($locales,$domains,$this->transPaths);if (!$domains) {$domains =$this->getDomainsFromTranslatorBag($localTranslations);}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done
c9d787d tod4d0bb2Comparechalasr commentedMay 6, 2022
If there is no relevant way to add a test for this, can we at least put a phpdoc comment to ease catching regressions? |
d4d0bb2 to8b0f7ebCompareFlorian-B commentedMay 6, 2022
Done 👍 |
chalasr commentedMay 6, 2022
Good catch, thanks@Florian-B. |
Since#45171 it's possible to define targeted translation domains in configuration.
On
translation:pushwithout--domainsoption the command should read our configuration in order build local translations list.If the domain is only define in the configuration we need to refresh the local translations list to prevent full update of Provider (push all domains without filtering).
I think we should add a test but I failed to do it properly.