Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix docblock types of Command::addOption()#46218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mostafa-re commentedApr 29, 2022
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#46140 |
| License | MIT |
| Doc PR | - |
wouterj commentedApr 29, 2022
Hi there! The omitted type is intended, to avoid the duplication between the type in the argument list and the PHPdoc (this can only get out-of-sync). According to thespecification of phpDocumentor (and the related "draft" PSR), the type can be omitted in
This is actually anopen bug in phpstorm. |
chalasr commentedApr 30, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Although the codebase is not consistent on this point (that's another topic), I'm 👎 for the reason given by Wouter: this is a PHPStorm bug, not a Symfony one. Thanks for proposing, hope to see you in another contrib |