Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix docblock types of Command::addOption()#46218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mostafa-re wants to merge1 commit intosymfony:6.0frommostafa-re:docblock-fix-6.0

Conversation

@mostafa-re
Copy link

QA
Branch?6.0
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#46140
LicenseMIT
Doc PR-

Zarthus reacted with heart emoji
@wouterj
Copy link
Member

Hi there!

The omitted type is intended, to avoid the duplication between the type in the argument list and the PHPdoc (this can only get out-of-sync). According to thespecification of phpDocumentor (and the related "draft" PSR), the type can be omitted in@param:

With the@param tag it is possible to document theType and the intent of a singleargument of a function or method.When provided it MAY contain aType to indicate what is expected.

This is actually anopen bug in phpstorm.

@chalasr
Copy link
Member

chalasr commentedApr 30, 2022
edited
Loading

Although the codebase is not consistent on this point (that's another topic), I'm 👎 for the reason given by Wouter: this is a PHPStorm bug, not a Symfony one. Thanks for proposing, hope to see you in another contrib

@chalasrchalasr removed their request for reviewApril 30, 2022 15:38
@wouterjwouterj mentioned this pull requestJan 3, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mostafa-re@wouterj@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp