Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Add Infobip bridge#46211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromB-Galati:infobip-mailer
Jul 20, 2022
Merged

Conversation

@B-Galati
Copy link
Contributor

@B-GalatiB-Galati commentedApr 29, 2022•
edited by OskarStark
Loading

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRsymfony/symfony-docs#16760

Hello,

Add Infobip as new email provider for Symfony Mailer!

Co-authored with@jbdelhommeau 👍

ismail1432 reacted with thumbs up emoji
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some minor comments, thank you

@B-Galati
Copy link
ContributorAuthor

@OskarStark Thanks! All fixed, hope I did not forget anything 👍

OskarStark, jbdelhommeau, and ismail1432 reacted with rocket emoji

@B-GalatiB-Galatiforce-pushed theinfobip-mailer branch 2 times, most recently fromb7df661 to87d660cCompareMay 2, 2022 09:28
@B-Galati
Copy link
ContributorAuthor

just done a little update to fix the SMTP client, all good now.

@B-Galati
Copy link
ContributorAuthor

Rebased with last commit to check if it fixes psalm error.

@fabpotfabpot modified the milestones:6.1,6.2May 8, 2022
@B-Galati
Copy link
ContributorAuthor

@OskarStark I know it's a bit late but do you know if it could be released with 6.1?

@fabpot
Copy link
Member

We’ve been in feature freeze for more than a month now, so it’ll be for 6.2 unfortunately.

B-Galati reacted with thumbs up emoji

@B-Galati
Copy link
ContributorAuthor

Thank you, I will change the branch target then 👍

@OskarStarkOskarStark requested a review fromfabpotJune 1, 2022 12:24
fabpot added a commit that referenced this pull requestJun 2, 2022
This PR was merged into the 5.4 branch.Discussion----------[Mailer] Sort transports alphabetically| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Spotted in#46211| License       | MIT| Doc PR        | -So the sorting does not needs to be done in#46211cc@B-GalatiCommits-------5d76dbb [Mailer] Sort transports alphabetically
@fabpot
Copy link
Member

@B-Galati Are you still interested in finishing this PR?

@B-Galati
Copy link
ContributorAuthor

Yes@fabpot 👍

Co-Authored-By: Jean-Baptiste Delhommeau <jeanbadel@gmail.com>Co-Authored-By: Benoit Galati <benoit.galati@gmail.com>
@B-Galati
Copy link
ContributorAuthor

@fabpot it's ready, the CI failure looks unrelated but I am may be wrong of course.

@fabpot
Copy link
Member

@B-Galati Can you create a PR on symfony/recipes?

B-Galati reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@B-Galati.

B-Galati reacted with heart emoji

@fabpotfabpot merged commitc5aeafe intosymfony:6.2Jul 20, 2022
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestJul 23, 2022
This PR was merged into the 6.2 branch.Discussion----------[Mailer] Add Infobip bridgeHello,Companion forsymfony/symfony#46211!Commits-------f14ec5d [Mailer] Add Infobip bridge
@B-GalatiB-Galati deleted the infobip-mailer branchJuly 26, 2022 09:07
@B-Galati
Copy link
ContributorAuthor

PR for the recipe openedsymfony/recipes#1113 ✔️

@xabbuhxabbuh mentioned this pull requestJul 29, 2022
fabpot added a commit that referenced this pull requestJul 29, 2022
This PR was merged into the 6.2 branch.Discussion----------[Mailer] re-add test| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |This test was initially added in#46211 but failed because of the changes from#46963 that were merged in the meantime. The test was then removed ine54dd38. This is a fixed version that is passing again.Commits-------1026e16 re-add test
@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@B-Galati@fabpot@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp