NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer] Restore X-Transport after failure#46154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4fromzenas1210:ticket_44741

Apr 27, 2022

Merged

[Mailer] Restore X-Transport after failure#46154

fabpot merged 1 commit intosymfony:4.4fromzenas1210:ticket_44741

Apr 27, 2022

Conversation

Copy link

Contributor

zenas1210 commentedApr 24, 2022

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#44741
License	MIT
Doc PR

Restores X-Transport header for retries after failure.

carsonbot added Status: Needs Review Bug Mailer labels

Apr 24, 2022

carsonbot added this to the4.4 milestone

Apr 24, 2022

Copy link

carsonbot commentedApr 24, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot