Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Modify processing of uploaded files to be compatible with PHP 8.1#46149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromp-golovin:p-golovin-patch-1
Apr 23, 2022

Conversation

@p-golovin
Copy link
Contributor

@p-golovinp-golovin commentedApr 22, 2022•
edited
Loading

Remove full_path from keys before check
Keep logic the same as in src/Symfony/Component/HttpFoundation/FileBag.php

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#46146
LicenseMIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@stof
Copy link
Member

should be merged in 4.4 actually. Can you rebase your branch on top of 4.4 (and change the PR target branch then) ?

Remove full_path from keys before checkKeep logic the same as in src/Symfony/Component/HttpFoundation/FileBag.php
@p-golovin
Copy link
ContributorAuthor

Branch is rebased on top of 4.4

@fabpotfabpot changed the base branch from5.4 to4.4April 23, 2022 15:22
@fabpot
Copy link
Member

Thank you@p-golovin.

@fabpotfabpot merged commitf0ffa47 intosymfony:4.4Apr 23, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@ycerutoycerutoyceruto approved these changes

@chalasrchalasrchalasr approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@p-golovin@carsonbot@stof@fabpot@yceruto@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp