NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Add support for route attributes in kernel controller methods#46115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 0 commits intosymfony:6.1fromdunglas:feat/route-attributes-in-kernel

Apr 20, 2022

Merged

[FrameworkBundle] Add support for route attributes in kernel controller methods#46115

fabpot merged 0 commits intosymfony:6.1fromdunglas:feat/route-attributes-in-kernel

Apr 20, 2022

Conversation

Copy link

Member

dunglas commentedApr 19, 2022

Q	A
Branch?	6.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	todo

Simplify creating single file projects using route attributes:

<?phprequire__DIR__.'/vendor/autoload.php';useSymfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;useSymfony\Component\HttpFoundation\Response;useSymfony\Component\HttpKernel\KernelasBaseKernel;useSymfony\Component\Routing\Annotation\Route;class Kernelextends BaseKernel{use MicroKernelTrait;    #[Route('/')]publicfunctionhomepage()    {returnnewResponse('Hello, world');    }}$app =newKernel($_SERVER['APP_ENV'] ??'prod',$_SERVER['APP_DEBUG'] ??false);if (\PHP_SAPI ==='cli') {$application =newApplication($app);exit($application->run());}$request = Request::createFromGlobals();$response =$app->handle($request);$response->send();$app->terminate($request,$response);

This will also allow removing these lines from the FrameworkBundle recipe:https://github.com/symfony/recipes/blob/master/symfony/routing/6.0/config/routes.yaml#L5-L7

dunglas requested a review fromnicolas-grekas

April 19, 2022 22:36

carsonbot added Status: Needs Review Feature FrameworkBundle labels

Apr 19, 2022

carsonbot added this to the6.1 milestone

Apr 19, 2022

dunglas force-pushed thefeat/route-attributes-in-kernel branch from489fbdc to1e248e2Compare

April 19, 2022 22:47

nicolas-grekas reviewed

Apr 20, 2022

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice :)
please add a line on the changelog of the component
we now need to update the recipe for symfony/routing 6.1
can you please send a PR ?

src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php OutdatedShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.phpShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/Kernel/MicroKernelTraitTest.php OutdatedShow resolvedHide resolved

Copy link

Contributor

fancyweb commentedApr 20, 2022

Should we deprecate declaring routes with the->controller([$this, 'foo']) or->controller($this->foo(...)) syntaxes then? I feel like being able to use theRoute attribute directly without any configuration fills the same need but in a better way.

Copy link

Member

nicolas-grekas commentedApr 20, 2022•
edited
Loading

Deprecating always has a cost, which needs to be justified. What would be the justification for the migration cost?

Copy link

MemberAuthor

dunglas commentedApr 20, 2022•
edited
Loading

The "old" syntax still has use cases: for instance, you may want to register methods as controllers dynamically (using reflection or complex things like this). I would keep it (and it has been supported for years). However, we could update the docs to promote the new syntax.