Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] Don't allow empty username or empty password#46109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@bikalbasnet
Copy link

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#46100
LicenseMIT
Doc PR-

First time PR on Symfony. So apologies for any mistake.
As I understand if I merge on 5.4, it will be merged to 6.0 and other higher version, let me know if I need to open PR in multiple branch.

@chalasr
Copy link
Member

Thanks for contributing to Symfony!
Since we never required non-empty-string usernames/passwords at the authentication level, even under the old security system, I'd call this a new feature. As such, this change should target 6.2 and be mentioned in the Security/Http/CHANGELOG.
The 6.2 branch does not exist yet so you will need to target 6.1 for now.

bikalbasnet reacted with thumbs up emoji

@chalasrchalasr modified the milestones:5.4,6.2Apr 19, 2022
@bikalbasnetbikalbasnet deleted the 5.4-not-allow-empty-usr-pwd branchApril 20, 2022 04:15
@fabpotfabpot removed this from the6.2 milestoneMay 8, 2022
fabpot added a commit that referenced this pull requestJul 20, 2022
…d (bikalbasnet)This PR was squashed before being merged into the 6.2 branch.Discussion----------[Security] Don't allow empty username or empty password| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes| Deprecations? | yes| Tickets       |#46100| License       | MIT| Doc PR        | -<!--Replace this notice by a short README for your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against the latest branch. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->Reopened from#46109 into `6.1` branch as this is not a bug rather a security featureCommits-------db5afbd [Security] Don't allow empty username or empty password
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bikalbasnet@chalasr@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp