Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security][SecurityBundle] Move theSecurity helper to SecurityBundle#46094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromchalasr:mv-sec-helper
Jun 5, 2022

Conversation

chalasr
Copy link
Member

@chalasrchalasr commentedApr 17, 2022•
edited
Loading

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?yes
TicketsFixes#46066 (comment)
LicenseMIT
Doc PRtodo

TheSecurity helper is a high-level service providing an easy access to commonly-needed features coming from various low-level abstractions. Basically, it's a facade.
Based on this, it makes sense to me to make it available only via the full-stack framework, as proposed by Wouter in#46066 (comment).

This unlocks#46066,#41274 and#41406.
/cc@wouterj@johnkrovitch@Kocal

alexander-schranz reacted with thumbs up emojiKocal, johnkrovitch, kbond, and bikalbasnet reacted with heart emoji
@carsonbotcarsonbot added this to the6.1 milestoneApr 17, 2022
@chalasrchalasr modified the milestones:6.1,6.2Apr 17, 2022
@chalasrchalasrforce-pushed themv-sec-helper branch 3 times, most recently from47827d2 to741cf2aCompareApril 17, 2022 23:23
@Kocal
Copy link
Member

Thanks@chalasr! 😍

@chalasrchalasrforce-pushed themv-sec-helper branch 2 times, most recently from116495a to8060907CompareMay 30, 2022 18:38
@chalasr
Copy link
MemberAuthor

Rebased on 6.2

johnkrovitch reacted with thumbs up emoji

@carsonbotcarsonbot changed the title[Security] Move theSecurity helper to SecurityBundle[Security][SecurityBundle] Move theSecurity helper to SecurityBundleMay 30, 2022
Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for working on this!

@chalasrchalasrforce-pushed themv-sec-helper branch 4 times, most recently from0ed5d7a to0c0f95fCompareMay 31, 2022 20:15
Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good to me!

@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit0140746 intosymfony:6.2Jun 5, 2022
@chalasrchalasr deleted the mv-sec-helper branchJune 5, 2022 21:09
chalasr added a commit that referenced this pull requestJun 6, 2022
…elper (HypeMC)This PR was merged into the 6.2 branch.Discussion----------[SecurityBundle] Add service alias for legacy Security helper| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | yes| New feature?  | no| Deprecations? | yes| Tickets       | -| License       | MIT| Doc PR        | -The service alias for `Symfony\Component\Security\Core\Security` was removed in#46094 which causes existing code to break when upgrading to 6.2, eg:```phpuse Symfony\Component\Security\Core\Security;class HomeController extends AbstractController{    public function __construct(private Security $security)    {    }}```results in:![image](https://user-images.githubusercontent.com/2445045/172196153-dbcacf0e-0632-40ad-87a2-bbe7774cc698.png)Commits-------0b81a75 [SecurityBundle] Add service alias for legacy Security helper
@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@wouterjwouterjwouterj approved these changes

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

7 participants
@chalasr@Kocal@fabpot@stof@wouterj@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp