What's the best way to make the low-deps check passing?

What's the best way to make the low-deps check passing?

By requiring^6.2 in the composer.json (or skipping the test on lower versions).

However, this does signal the design flaw of the current implementation (which is a flaw with theSecurity class as a whole, but highlighted more by this change): We now have a class inSecurity\Core that depends on aFirewallMap andFirewallConfig class fromSecurityBundle, which depend on aFirewallMap fromSecurity\Http. Imho, that sadly is a no go, so 👎 for the moment.

Please note that this is purely a -1 for the implementation, I think the DX problem highlighted in the issue is worth fixing.

@chalasr this is the second time we have a nice DX improvement that introduces lots of coupling through theSecurity helper class (ref#41274 (comment)). What do you think about deprecating this helper class inSecurity\Core and moving it completely to the SecurityBundle? That directly resolves coupling issues, and only reduces DX for standalone users (all methods in the class are little helpers to retrieve information more easily, none add missing functionality), which - to be honest - already suffer from a bad DX. And given the currently coupling to SecurityBundle service names in the class, I don't expect standalone users are using the class at the moment.

Having theSecurity class in theSecurityBundle makes more sense to me, I was dubitative when working on the feature.

Big 👍 for moving the helper to SecurityBundle.

The merge tool was a bit trigger happy closing this PR when#46094 got merged, reopening.

@Kocal do you have time to rebash and finish this PR for 6.2, now the helper is moved to the security bundle?

I'm glad that#46094 has been merged, nice work@chalasr :)

@wouterj the PR has been rebased and modified in consequence.

Thank you@Kocal.

@Kocal Nice work. Thx for implementing this 👍