Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Add aChainUserChecker to allow calling multiple user checkers for a firewall#46064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
b79f4f8 tofdf2d0fCompareUh oh!
There was an error while loading.Please reload this page.
ChainUserChecker to allow calling multiple user checkers for a firewall1b73f8f to711b918Comparemaxhelias approved these changesSep 12, 2022
derrabus approved these changesSep 12, 2022
711b918 to0a1ad4bComparefabpot approved these changesSep 13, 2022
Member
fabpot commentedSep 13, 2022
Thank you@mbabker. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I had a case in one of my apps where I have some shared logic for user checkers across multiple firewalls (API and traditional web login) while also needing extra logic for the API. Instead of duplicating the checker for each firewall or using a decorator, I thought a chained user checker would be nice to have and that it might be useful to users of the framework.
This will add a
ChainUserCheckerclass to thesecurity-corecomponent, and the SecurityBundle will create asecurity.user_checker.chain.<firewall>service for each firewall. User checkers can then be tagged with asecurity.user_checker.<firewall>tag for each firewall the checker applies to, and users would set this chain service as the user checker for their firewall.