Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] Add support for promoted properties in PhpStanExtractor#46056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f68081a to9b1b2d2CompareEmilMassey approved these changesApr 16, 2022
nicolas-grekas approved these changesApr 19, 2022
dunglas approved these changesApr 19, 2022
| */ | ||
| publicfunctiontestExtractPhp80Type($property,array$type =null) | ||
| { | ||
| $this->assertEquals($type,$this->extractor->getTypes('Symfony\Component\PropertyInfo\Tests\Fixtures\Php80Dummy',$property, [])); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| $this->assertEquals($type,$this->extractor->getTypes('Symfony\Component\PropertyInfo\Tests\Fixtures\Php80Dummy',$property, [])); | |
| $this->assertEquals($type,$this->extractor->getTypes(Php80Dummy::class,$property, [])); |
Member
nicolas-grekas commentedApr 19, 2022
Thank you@simPod. |
Merged
nicolas-grekas added a commit that referenced this pull requestMay 17, 2022
…ies in PhpStanExtractor (BoShurik)This PR was merged into the 6.1 branch.Discussion----------[PropertyInfo] Ignore empty doc-block for promoted properties in PhpStanExtractor| Q | A| ------------- | ---| Branch? | 6.1| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Fix processing empty doc-block for promoted properties (introduced in#46056)<!--Replace this notice by a short README for your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against the latest branch. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->Commits-------410d7f2 [PropertyInfo] Ignore empty doc-block for promoted properties in PhpStanExtractor
ostrolucky added a commit to ostrolucky/symfony that referenced this pull requestJun 1, 2022
…d propertiesThis demonstrates thatsymfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
ostrolucky added a commit to ostrolucky/symfony that referenced this pull requestJun 1, 2022
…d propertiesThis demonstrates thatsymfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
simPod pushed a commit to simPod/symfony that referenced this pull requestJun 7, 2022
…d propertiesThis demonstrates thatsymfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
simPod pushed a commit to simPod/symfony that referenced this pull requestJun 10, 2022
…d propertiesThis demonstrates thatsymfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
symfony-splitter pushed a commit to symfony/property-info that referenced this pull requestJun 10, 2022
…d propertiesThis demonstrates thatsymfony/symfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
nathansalter pushed a commit to nathansalter/symfony that referenced this pull requestJun 11, 2022
…d propertiesThis demonstrates thatsymfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for promoted properties in PhpStanExtractor