Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] smsapi - send messages in test mode#46047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@n3crone
Copy link

@n3cronen3crone commentedApr 15, 2022•
edited by wouterj
Loading

QA
Branch?6.1
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Add possibility to send messages in test mode where they are validated only (not sent, not charged).

Official documentation:https://www.smsapi.pl/docs/#2-pojedynczy-sms

test - Wiadomość nie jest wysyłana, wyświetlana jest jedynie odpowiedź (w celach testowych). (&test=1)

Not sure about tests.

whatsupmike and piotr-stefanski reacted with heart emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Thank you@n3crone.

@OskarStark
Copy link
Contributor

@nicolas-grekas sorry I was to late, the tests are wrong

nicolas-grekas added a commit that referenced this pull requestApr 19, 2022
…hen `true` (OskarStark)This PR was squashed before being merged into the 6.1 branch.Discussion----------[Notifier] [Smsapi] Show `test` and `fast` in DSN only when `true`| Q             | A| ------------- | ---| Branch?       | 6.1| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Follows#46047| License       | MIT| Doc PR        | --Commits-------692e277 [Notifier] [Smsapi] Show `test` and `fast` in DSN only when `true`
@fabpotfabpot mentioned this pull requestApr 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark left review comments

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

4 participants

@n3crone@carsonbot@nicolas-grekas@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp