Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] Get domains from provider if them are not specified explicitly#45999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
247d038 toabd0805Compare| if (!$domains) { | ||
| $domains =$this->getDomainsFromTranslatorBag($localTranslations); | ||
| $domains =$provider->getDomains(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need to check if$provider hasgetDomains method here, as it's done herehttps://github.com/symfony/symfony/pull/45171/files#diff-a00f86baf85c337ee61148e5fff8d189edf224ef40382518307359f579f40e6aR136
welcoMattic commentedApr 12, 2022
@ossinkine Thank you for the contribution. Can you add a test to cover this change please? |
ossinkine commentedMay 12, 2022
Looks like it's already fixed in#45171, closing |
The command
translation:pullgets domains from provider configuration if them are not specified in options buttranslation:pushgets domans from local catalog. I find that the same behavior is more predictable in this case.symfony/src/Symfony/Component/Translation/Command/TranslationPullCommand.php
Lines 154 to 156 in1f514f9