Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (seehttps://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
• Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

In 5.2, we deprecated theallowEmptyString, see#36818 by@xabbuh
I think the behavior on 6.0 is expected now, isn't it?

I just looked at the ticket but: there are about thirty validators that authorize an empty string? Why a different behavior for this one?

I just looked at the ticket but: there are about thirty validators that authorize an empty string? Why a different behavior for this one?

This decision was made in#31528 because the semantic ofLength(min: 1) wasn't fulfilled and the result unexpected to me since it allowed empty strings.
This is different from any other constraints, since the Length onespecifically is about the string length. Other constraints are conveniently ignoring empty strings, because they cannot perform any validation on it.

Also, the DX for a nullable string property requiring at least 1 char (hence reject empty strings) — which is a common use-case for clean data types — was bad, requiring to write:

#[Length(min:1)] <- was actually completely uselessand unintuitive, since it was allowing empty strings despite min:1#[NotBlank(allowNull:true)] <- was too indirect to express empty strings are not allowed but the property is nullable

If you really wish to allow empty strings, you can use:

#[AtLeastOneOf([newLength(0),newLength(min:6),])]

which would be explicit about this use-case.

Closing as explained. Thanks for asking and the answers :)