Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Return-Path has higher priority for envelope address than From address#45992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedApr 11, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedApr 11, 2022
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
fabpot commentedApr 11, 2022
This should be on 4.4 instead. |
tpetry commentedApr 11, 2022
Ok, I'll rebase it onto 4.4 😉 |
tpetry commentedApr 11, 2022
@fabpot Can you re-run the workflows? I missed changing the new base branch information in the Github Pull Request setting. |
andjsch commentedApr 11, 2022
This is great! I am having the issue with Laravel 9 not setting the Return Path on the sent email correctly. It's always the sender email. Thanks for the PR! |
fabpot commentedApr 12, 2022
Thank you@tpetry. |
…n SES API transport (xabbuh)This PR was merged into the 5.4 branch.Discussion----------[Mailer] prefer From header over Return-Path as sender in SES API transport| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | related to the changes made in#45992| License | MIT| Doc PR |Commits-------c6174eb prefer From header over Return-Path as sender in SES API transport
Uh oh!
There was an error while loading.Please reload this page.