Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Return-Path has higher priority for envelope address than From address#45992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4frommailspice:return-path-priority
Apr 12, 2022

Conversation

@tpetry
Copy link
Contributor

@tpetrytpetry commentedApr 11, 2022
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41322
LicenseMIT
Doc PR-

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@fabpot
Copy link
Member

This should be on 4.4 instead.

@tpetry
Copy link
ContributorAuthor

Ok, I'll rebase it onto 4.4 😉

@tpetrytpetry requested a review fromchalasr as acode ownerApril 11, 2022 10:40
@tpetrytpetry changed the base branch from6.0 to4.4April 11, 2022 10:42
@tpetry
Copy link
ContributorAuthor

@fabpot Can you re-run the workflows? I missed changing the new base branch information in the Github Pull Request setting.

@fabpotfabpot modified the milestones:6.0,4.4Apr 11, 2022
@andjsch
Copy link

This is great! I am having the issue with Laravel 9 not setting the Return Path on the sent email correctly. It's always the sender email.

Thanks for the PR!

@fabpot
Copy link
Member

Thank you@tpetry.

@fabpotfabpot merged commit6af4986 intosymfony:4.4Apr 12, 2022
@tpetrytpetry deleted the return-path-priority branchApril 12, 2022 06:23
nicolas-grekas added a commit that referenced this pull requestApr 12, 2022
…n SES API transport (xabbuh)This PR was merged into the 5.4 branch.Discussion----------[Mailer] prefer From header over Return-Path as sender in SES API transport| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | related to the changes made in#45992| License       | MIT| Doc PR        |Commits-------c6174eb prefer From header over Return-Path as sender in SES API transport
This was referencedApr 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@tpetry@carsonbot@fabpot@andjsch@chalasr

[8]ページ先頭

©2009-2025 Movatter.jp