Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] deprecate not setting http_method_override#45989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Tobion
Copy link
Contributor

@TobionTobion commentedApr 11, 2022•
edited
Loading

QA
Branch?6.1
Bug fix?no
New feature?no
Deprecations?yey
TicketsFix#45278
LicenseMIT
Doc PR

In preparation for changing the default in 7.0.

->children()
->scalarNode('secret')->end()
->scalarNode('http_method_override')
->booleanNode('http_method_override')
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The only boolean node that wasn't defined as such and missed validation.

->booleanNode('http_method_override')
->info("Set true to enable support for the '_method' request parameter to determine the intended HTTP method on POST requests. Note: When using the HttpCache, you need to call the method in your front controller instead")
->defaultTrue()
->treatNullLike(false)
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

currently setting it to null caused a type error in the FrameworkExtension which is now fixed. making it a boolean node still permits null. so this also ensures that null is transformed to false (instead of true which is the default in boolean node)

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Please add CHANGELOG+UPGRADE entries

@Tobion
Copy link
ContributorAuthor

@nicolas-grekas I need to adapt tests don't I? The option needs to be set in alot of functional tests.

@nicolas-grekas
Copy link
Member

yes indeed

@Tobion
Copy link
ContributorAuthor

Tobion commentedApr 19, 2022•
edited
Loading

@nicolas-grekas is there a way to ignore this deprecation notice in Symfony tests when it's self triggered. otherwise I have to explicitly set the http_method_override: false in hundrets of test fixtures. kinda ugly and pointless.
There are 114 yml files alone. Then the likely the same amount in xml and php.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedApr 19, 2022•
edited
Loading

Nope there's none, and that's on purpose to me: eat our own dog food. We're asking ppl to opt-in, including ourselves.

GromNaN and ogizanagi reacted with thumbs up emoji

@GromNaNGromNaN changed the title[FrameworkBundle] deprecate not setting http_method_overwrite[FrameworkBundle] deprecate not setting http_method_overrideApr 19, 2022
@Tobion
Copy link
ContributorAuthor

Well, users will not be affected when using the recipes. And the people who are, only need to change 1 line. We have to adjust hundrets of unrelated tests.

@TobionTobionforce-pushed thedeprecate-not-setting-http-method-overwrite branch from8b29d0d to9be468fCompareApril 20, 2022 13:27
@TobionTobionforce-pushed thedeprecate-not-setting-http-method-overwrite branch 5 times, most recently frome1df1f7 toa156313CompareApril 20, 2022 14:19
@Tobion
Copy link
ContributorAuthor

I fixed the tests and adding changelog/upgrade. This is ready now.

@fabpotfabpotforce-pushed thedeprecate-not-setting-http-method-overwrite branch froma156313 tof9cf24aCompareApril 21, 2022 06:09
@fabpot
Copy link
Member

Thank you@Tobion.

@fabpotfabpot merged commitd838f46 intosymfony:6.1Apr 21, 2022
@TobionTobion deleted the deprecate-not-setting-http-method-overwrite branchJune 9, 2022 13:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

Disable http_method_override by default

5 participants

@Tobion@nicolas-grekas@fabpot@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp