Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] [Command] Fixdebug:router --no-interaction error …#45947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@WilliamBoulle
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#45777
LicenseMIT

When commanddebug:router is used in non-interactive mode with a name that matches more than one route, render the list of matching routes
debug_router_profiler_nointeraction

GromNaN reacted with thumbs up emoji
@carsonbotcarsonbot added this to the4.4 milestoneApr 5, 2022
@carsonbotcarsonbot changed the title[FrameworkBundle][Command] Fixdebug:router --no-interaction error …[FrameworkBundle] [Command] Fixdebug:router --no-interaction error …Apr 5, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this bug.
It would be perfect if you could add a test toRouterDebugCommandTest.

@WilliamBoulle
Copy link
ContributorAuthor

Thanks for the feedback, I try to add a test for the command

@WilliamBoulleWilliamBoulleforce-pushed theticket_45777 branch 2 times, most recently frombde4521 toe796b61CompareApril 6, 2022 09:15
@fabpot
Copy link
Member

Thank you@WilliamBoulle.

fabpot added a commit that referenced this pull requestApr 8, 2022
…tion` error … (WilliamBoulle)This PR was squashed before being merged into the 4.4 branch.Discussion----------[FrameworkBundle] [Command] Fix `debug:router --no-interaction` error …| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#45777| License       | MITWhen command `debug:router` is used in non-interactive mode with a name that matches more than one route, render the list of matching routes![debug_router_profiler_nointeraction](https://user-images.githubusercontent.com/18715733/161756561-cb2b5f75-111d-4920-8e81-8066b302a887.png)Commits-------e92e261 [FrameworkBundle] [Command] Fix `debug:router --no-interaction` error …
@fabpotfabpot closed thisApr 8, 2022
@WilliamBoulleWilliamBoulle deleted the ticket_45777 branchApril 8, 2022 08:14
This was referencedApr 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@GromNaNGromNaNGromNaN left review comments

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@WilliamBoulle@carsonbot@fabpot@GromNaN@chalasr

[8]ページ先頭

©2009-2025 Movatter.jp