Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] [Command] Fixdebug:router --no-interaction error …#45947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
debug:router --no-interaction error …debug:router --no-interaction error …carsonbot commentedApr 5, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
GromNaN left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for working on this bug.
It would be perfect if you could add a test toRouterDebugCommandTest.
src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
WilliamBoulle commentedApr 6, 2022
Thanks for the feedback, I try to add a test for the command |
bde4521 toe796b61Comparefabpot commentedApr 8, 2022
Thank you@WilliamBoulle. |
…tion` error … (WilliamBoulle)This PR was squashed before being merged into the 4.4 branch.Discussion----------[FrameworkBundle] [Command] Fix `debug:router --no-interaction` error …| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#45777| License | MITWhen command `debug:router` is used in non-interactive mode with a name that matches more than one route, render the list of matching routesCommits-------e92e261 [FrameworkBundle] [Command] Fix `debug:router --no-interaction` error …
When command

debug:routeris used in non-interactive mode with a name that matches more than one route, render the list of matching routes