Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Make LintCommand::$namePatterns private#45941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
GromNaN merged 1 commit intosymfony:6.1fromnicolas-grekas:twig-priv
Apr 4, 2022

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedApr 4, 2022•
edited
Loading

QA
Branch?6.1
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Dunno why this wasn't done in#45845. /cc@GromNaN any idea?

@GromNaN
Copy link
Member

GromNaN commentedApr 4, 2022•
edited
Loading

The attribute is used by child classSymfony\Bundle\TwigBundle\Command\LintCommand. Psalm found the issue.

Is there any alternative? Adding a protectedgetNamePattern? Auto-append theFinder instance returned byfindFiles?

@nicolas-grekas
Copy link
MemberAuthor

Understood, thanks. Fixed.

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Brilliant.

@GromNaN
Copy link
Member

Good catch, thanks@nicolas-grekas.

@GromNaNGromNaN merged commit9c37015 intosymfony:6.1Apr 4, 2022
@nicolas-grekasnicolas-grekas deleted the twig-priv branchApril 11, 2022 15:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@GromNaNGromNaNGromNaN approved these changes

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@GromNaN@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp