NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Process] Fix Process::getEnv() when setEnv() hasn't been called before#45931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.4fromasika32764:patch-1

Apr 4, 2022

Merged

[Process] Fix Process::getEnv() when setEnv() hasn't been called before#45931

nicolas-grekas merged 1 commit intosymfony:4.4fromasika32764:patch-1

Apr 4, 2022

Conversation

Copy link

Contributor

asika32764 commentedApr 4, 2022•
edited by nicolas-grekas
Loading

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT

ASgetEnv() return type is array, if aProcess object has no default env and is NULL value, callinggetEnv() will get error.

$process =$someObject->createProcess();// Get process from some object, but we don't know the environment// We want to check the env$env =$process->getEnv();// Error: return type must be array, NULL given.

carsonbot added Status: Needs Review Bug labels

Apr 4, 2022

carsonbot added this to the6.1 milestone

Apr 4, 2022

Copy link

carsonbot commentedApr 4, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

asika32764 changed the base branch from6.1 to6.0

April 4, 2022 09:05

asika32764 requested review fromOskarStark,chalasr,dunglas,jderusse,lyrixx,wouterj,xabbuh andyceruto ascode owners

April 4, 2022 09:05

asika32764 changed the base branch from6.0 to6.1

April 4, 2022 09:05

nicolas-grekas modified the milestones:6.1,4.4

Apr 4, 2022

nicolas-grekas reviewed

Apr 4, 2022

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch.
I think it might be better to initialize the property to the empty array, then we wouldn't have to patch this method.
Also, since this is a bugfix, it should target 4.4, and should have a test case. Can you add one please? (I can handle the re-targeting while merging)

Copy link

ContributorAuthor

asika32764 commentedApr 4, 2022

Sorry I have heavy work on my job, so I'm afraid that I'm not available to do future works.

Just fix it thought your standard way, thanks.

nicolas-grekas added the Process label

Apr 4, 2022

carsonbot changed the title~~Make Process::getEnv() default return array if is NULL~~[Process] Make Process::getEnv() default return array if is NULL

Apr 4, 2022

nicolas-grekas changed the title~~[Process] Make Process::getEnv() default return array if is NULL~~[Process] Fix Process::getEnv() when setEnv() hasn't been called before

Apr 4, 2022

nicolas-grekas changed the base branch from6.1 to4.4

April 4, 2022 10:15

nicolas-grekas force-pushed thepatch-1 branch from2ffb5c1 to5da4b8cCompare

April 4, 2022 10:15