Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] reset connection on worker shutdown#45910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] reset connection on worker shutdown#45910
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedApr 1, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| } | ||
| $this->dispatchEvent(newWorkerStoppedEvent($this)); | ||
| $this->dispatchEvent(newWorkerStoppedEvent($this,$this->receivers)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd prefer not adding a new class + argument
instead, we could add the reset loop after this call, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
True, good idea 👍
998c0eb toc486305Comparefabpot commentedApr 1, 2022
Thank you@SanderHagen. |
As seen in the issue. Amazon SQS transport uses a buffer. Messages can be lost when the buffer contains these messages and some container executing the process is shut down. The connection contains areset method and implements the
ResetInterface. If this method were to be called on shutdown the messages will be marked as visible again.