Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Fix the build#45905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 0 commits intosymfony:5.4fromwouterj:fix-build-54
Apr 1, 2022
Merged

[TwigBridge] Fix the build#45905

fabpot merged 0 commits intosymfony:5.4fromwouterj:fix-build-54
Apr 1, 2022

Conversation

@wouterj
Copy link
Member

@wouterjwouterj commentedMar 31, 2022•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix part of CI
LicenseMIT
Doc PRn/a
  • The changes in[TwigBridge] fix bootstrap_3_layout ChoiceType's expanded label_html #45897 missed the space between widget and label. Afaik, there is no other way to force the space than moving the if statement on the same line.
  • I've removed PHPunit bridge fromrequire-dev in the subtree splits. The PHPunit bridge is installed by the monorepo during local testing. Depending on it in subpackage's composer.json can create conflicts between the version installed by the monorepo and the subtree split package (especially on deps=low builds). The build was broken due to mixing up 4.4.0 and 6.1-dev in deps=low.
  • Finally, Appveyor seems to need to run a second time on each version branch for8016293 to work. Not sure why, but if it works it works 🏃

@carsonbotcarsonbot added this to the5.4 milestoneMar 31, 2022
@wouterjwouterj changed the title[TwigBridge] Fix whitespace control in boostrap 3 layout[TwigBridge] Fix the buildMar 31, 2022
@wouterjwouterj changed the title[TwigBridge] Fix the build[TwigBridge][DoctrineBridge] Fix the buildMar 31, 2022
@carsonbotcarsonbot changed the title[TwigBridge][DoctrineBridge] Fix the build[TwigBridge] Fix the buildApr 1, 2022
@fabpot
Copy link
Member

Thank you@wouterj.

@fabpotfabpot merged commit08966f7 intosymfony:5.4Apr 1, 2022
@wouterjwouterj deleted the fix-build-54 branchApril 1, 2022 06:10
This was referencedApr 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@wouterj@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp