Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (seehttps://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
• Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

The bug ticket says that Symfony 5 is affected by this bug. If that were the case, we would need to target the 5.4 branch. Can you please check?

I can do a PR for 5.4 too. But the bug is available on 6.x

@nicolas-grekas the issue number of the PR title or description? Title I suppose.

Title. 🙂

About the branch, we merge 5.4 into 6.0 periodically so 6.0 will also get the fix even if we merge this on 5.4

Thank you for the information about the cycle.
@nicolas-grekas, In my case I created the PR on 6.0. I can't change the original branch (maybe a rebase?). Either I recreate the PR or? It's not possible to change the from of PR.

Sorry for the inconvenience but it will be taken care of for the next ones.

git rebase 6.0 --onto 5.4

If rebase aborts because of conflicts, solve them and run:

git add.git rebase --continue

Once the rebase completed, run:

git push -f

Afterwards, you should be able to switch the base branch to 5.4.

Thanks@derrabus, I was close with my rebase ;) I must have missed a parameter!

Thank you@ytilotti.