Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Add mysql indexes back and work around deadlocks using soft-delete#45888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromnicolas-grekas:msg-deadlock
Mar 31, 2022

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#42868
LicenseMIT
Doc PR-

#42345 removed some indexes because they create too many deadlocks when running many concurrent consumers.
Yet, as reported in the linked issue, those indexes are useful when processing large queues (typically the failed messages queue).

#45007 is proposing to add an option to force the indexes back, but I don't like it because it requires ppl to learn about the issue. I looked for a more seamless solution and here is my proposal.

Instead of possibly triggering the deadlock duringack()/reject(), I propose to use a soft-delete there, and do the real delete inget(). This makes ack/reject safe because they don't alter any indexes anymore (the delete was), and this moves deadlock exceptions to the same function that creates the locks. This allows the retry mechanism inDoctrineReceiver to recover from at most 3 consecutive deadlock exceptions. There can be more, and in this case, the consumer will stop. But this should be much less likely.

(yes, I did create a reproducer to work on this issue ;) )

jeroennoten, gianiaz, dmaicher, and tinpansoul reacted with thumbs up emojitorbenbr reacted with heart emojidmaicher reacted with rocket emoji
@nicolas-grekasnicolas-grekas merged commit888e552 intosymfony:4.4Mar 31, 2022
This was referencedApr 2, 2022
@nicolas-grekasnicolas-grekas deleted the msg-deadlock branchApril 3, 2022 15:55
bobvandevijver added a commit to Drenso/argus that referenced this pull requestApr 4, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp