Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Render all throwables the same, including \Error subclasses#45885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Seldaek commentedMar 30, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There is a test failure - related to#22690 - maybe@chalasr can help here. It seems rethrowing was needed in the Symfony context so the symfony/debug handlers can do their job, but when using symfony/console inside Composer for example all I end up with is an unstyled error output from the native PHP uncaught exception handler. I worked around this incomposer/composer@af3e67e for the time being, as I wanted to render those type errors nicer, and also note I forced the stack trace to be shown for \Error (and its children) & \LogicException (not its children tho as things like InvalidArgumentException I wouldn't necessarily consider programming errors). Because getting error reports for things like type errors which are definitely program errors without stack trace is a real pain. So feel free to close here if you think it's unreasonable, but I find the current state a slightly strange behavior for non-symfony-framework users of symfony/console. |
chalasr commentedMar 30, 2022
Oh h*ck not this topic again 😅 |
Seldaek commentedMar 30, 2022
Yes I saw there's some history there :) That's why I said it's fine for me to close as well, I could achieve what I needed to achieve on my end, so no big deal. |
chalasr commentedMar 30, 2022
Sorry I didn't mean to close! Let me check this. |
nicolas-grekas commentedMay 14, 2022
Closing as explained, too risky for 4.4 at least. |
I'm not sure why only \Exception was caught here. These should also be included and rendered nicely IMO:
I believe it's an omission and hence worth a bugfix, but maybe I missed something.