Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Try all possible denormalization route with union types when ALLOW_EXTRA_ATTRIBUTES=false#45861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromT-bond:ticket_45860
Jun 19, 2022

Conversation

T-bond
Copy link
Contributor

@T-bondT-bond commentedMar 27, 2022•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#45860
LicenseMIT
Doc PR-

I found a similar bug, (I think this is a bug, but it is possible, it is an intended behaviour) to my previous report.

Copy link
ContributorAuthor

@T-bondT-bond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Self review done.

Failing tests seems unrelated.

@carsonbot
Copy link

Hey!

I think@Th3Mouk has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@NorthBlue333
Copy link

NorthBlue333 commentedJun 12, 2022•
edited
Loading

Hello there,
I am currently working on#46284, and was wondering about the state of this PR. I made a comment because IMO we should not merge the extraAttributes of all different types, but just return one set failing.
Ideally this should be merged before my PR because I will have to adjust the code.

@T-bond
Copy link
ContributorAuthor

This PR is ready for review.
If reviewed, and accepted I will rebase to resolve the conflicts.

@nicolas-grekasnicolas-grekas changed the title[Serializer] Try all possible denormalization route with union types …[Serializer] Try all possible denormalization route with union types when ALLOW_EXTRA_ATTRIBUTES=falseJun 19, 2022
@nicolas-grekas
Copy link
Member

Thank you@T-bond.

T-bond reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit0523bd3 intosymfony:4.4Jun 19, 2022
nicolas-grekas added a commit that referenced this pull requestJun 26, 2022
…tor (Gwemox)This PR was merged into the 4.4 branch.Discussion----------[Serializer] Fix denormalization union types with constructor| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#46396| License       | MITFix bug when deserialize union types with constructor. Before that, `MissingConstructorArgumentsException` was thrown even if another type matched.Is similar to#45861Commits-------33fb153 [Serializer] Fix denormalization union types with constructor
This was referencedJun 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@NorthBlue333NorthBlue333NorthBlue333 left review comments

@dunglasdunglasdunglas approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

5 participants
@T-bond@carsonbot@NorthBlue333@nicolas-grekas@dunglas
[8]ページ先頭
©2009-2025 Movatter.jp