NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] Add Http Status 423 LockedHttpException#45833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.1fromxosofox:lockedhttpexception423

Mar 26, 2022

Merged

[HttpKernel] Add Http Status 423 LockedHttpException#45833

fabpot merged 1 commit intosymfony:6.1fromxosofox:lockedhttpexception423

Mar 26, 2022

Conversation

Copy link

Contributor

xosofox commentedMar 24, 2022•
edited by nicolas-grekas
Loading

Q	A
Branch?	6.1
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	none
License	MIT
Doc PR	none

Add LockedHttpException (http status 423) to the list of predefined exceptions in HttpKernel

Not sure if this is considered to be a "new feature" that can only be merged into 6.x... I assume this could also be added to 5.x or 4.x even as it does not have any dependencies or side effects

Let me know if the base should be changed

carsonbot added Status: Needs Review HttpKernel labels

Mar 24, 2022

carsonbot added this to the5.4 milestone

Mar 24, 2022

Copy link

carsonbot commentedMar 24, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot