Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Let curl handle Content-Length headers#45814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromnicolas-grekas:hc-curl-length
Mar 22, 2022

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#45709
LicenseMIT
Doc PR-

@xabbuh
Copy link
Member

What about theNativeHttpClient?

@nicolas-grekas
Copy link
MemberAuthor

It already handles the situation.

@nicolas-grekasnicolas-grekas deleted the hc-curl-length branchMarch 22, 2022 15:07
@nicolas-grekas
Copy link
MemberAuthor

return0 !==stripos($h,'Content-Length:') &&0 !==stripos($h,'Content-Type:');

@xabbuh
Copy link
Member

From the little tests that I did that line is not enough and the patch as I did it in#45799 was needed too.

@nicolas-grekas
Copy link
MemberAuthor

Strange. Can you send a failing test case? Because the one I added here was fine with Native but hanging with Curl.

This was referencedApr 2, 2022
nicolas-grekas added a commit that referenced this pull requestJan 13, 2023
…as-grekas)This PR was merged into the 5.4 branch.Discussion----------[HttpClient] Let curl handle content-length headers| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#47973,#46499,#46823| License       | MIT| Doc PR        | -I'm not sure why (maybe some older and buggy curl versions?) but it looks like curl might send content-length headers to proxies.This didn't happen before#45261 so I'm trying to use curl in the same was as we did by the time, aka letting it handle content-length header when possible.This is something that I already attempted in#45814 but was partly reverted in#45998. The attached patch is free from such issue.Commits-------5b27dc2 [HttpClient] Let curl handle content-length headers
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp