Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix compatibility of ldap 6.0 with security 5.x#45804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.0fromjderusse:ldap-comp
Mar 24, 2022

Conversation

@jderusse
Copy link
Member

QA
Branch?6.0
Bug fix?yes
New feature?no
Deprecations?yes
Tickets-
LicenseMIT
Doc PR-

In version 5.4, theLdapAuthenticator class implements theAuthenticatorInterface and therefor implemented the deprecatedcreateAuthenticatedToken method.

In version 6.0, we removed that method from both the interface and theLdapAuthenticator class.

But the 2 class/interface are located in 2 differents packages, an our composer.json allows the combinationsymfony/ldap:6.0 +synfony/security-http:5.4. Leading to a fatal errorClass Symfony\Component\Ldap\Security\LdapAuthenticator contains 1 abstract method and must therefore be declared abstract or implement the remaining methods

This PR re-add the method in theldap component.

@carsonbot
Copy link

Hey!

I think@karlshea has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@wouterj
Copy link
Member

Hmm, I'm wondering how this slipped through the testsuite. Are we missing a compatibility test check here?

@chalasr
Copy link
Member

The LdapAuthenticator is not tested at all.

wouterj reacted with thumbs up emoji

@jderussejderusseforce-pushed theldap-comp branch 2 times, most recently from6cd65d1 toba3e8e4CompareMarch 23, 2022 08:03
@jderussejderusseforce-pushed theldap-comp branch 2 times, most recently from20cfff2 to5db5381CompareMarch 23, 2022 08:16
fabpot added a commit that referenced this pull requestMar 23, 2022
This PR was merged into the 5.4 branch.Discussion----------[Ldap] Add missing upgrade note for ldap| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -As suggested in#45804 (comment)Commits-------cd4d655 Add missing upgrade note for ldap
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedMar 23, 2022•
edited
Loading

GH is having issues closing PRs 😬

@fabpot
Copy link
Member

Thank you@jderusse.

@fabpotfabpot merged commit7d1aea4 intosymfony:6.0Mar 24, 2022
@fabpotfabpot mentioned this pull requestApr 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jderusse@carsonbot@wouterj@chalasr@nicolas-grekas@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp