Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] [LocoProvider] Add content-type for POST translations#45791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tomasz-kusy commentedMar 19, 2022
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#44031 |
| License | MIT |
| #44031 |
carsonbot commentedMar 20, 2022
Hey! I think@Kocal has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR. Just one comment and good to go on my side.
Uh oh!
There was an error while loading.Please reload this page.
…colas-grekas)This PR was merged into the 6.1 branch.Discussion----------[HttpClient] Improve default content-type handling| Q | A| ------------- | ---| Branch? | 6.1| Bug fix? | no| New feature? | yes (minor)| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -This improves the default behavior of handling the content-type header: with this PR, when an array is passed as body, the content-type is forced to `application/x-www-form-urlencoded`.This allows setting a content-type in the default options and have it overridden when passing an array as body.Spotted while reviewing#45791, where the proposed behavior would have allowed a cleaner patch.Commits-------91099a9 [HttpClient] Improve default content-type handling
fabpot commentedMar 26, 2022
Thank you@tomasz-kusy. |